ems-frontend icon indicating copy to clipboard operation
ems-frontend copied to clipboard

Ab#92212 avoid multiple subscriptions

Open MwanPygmay opened this issue 1 year ago • 0 comments

Description

When changing search we would not unsubscribe from options, and resubscribe, so we would have multiple subscriptions for the same object, resulting in weird behaviours.

Useful links

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Create a users question, try adding some, then search, then remove, readd...

Screenshots

No visual change

Checklist:

( * == Mandatory )

  • [x] * I have set myself as assignee of the pull request
  • [x] * My code follows the style guidelines of this project
  • [x] * Linting does not generate new warnings
  • [x] * I have performed a self-review of my own code
  • [x] * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • [x] * I have commented my code, particularly in hard-to-understand areas
  • [x] * I have put JSDoc comment in all required places
  • [x] * My changes generate no new warnings
  • [ ] * I have included screenshots describing my changes if relevant
  • [ ] * I have selected labels in the Pull Request, according to the changes with code brings
  • [ ] I have made corresponding changes to the documentation ( if required )
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

MwanPygmay avatar May 21 '24 14:05 MwanPygmay