ems-backend icon indicating copy to clipboard operation
ems-backend copied to clipboard

feat/AB#74292 People picker

Open TaiKamilla opened this issue 2 years ago • 6 comments

Description

In this PR the backend responds to the query GetPeople and send back some mock data

Useful links

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Improvement (refactor or addition to existing functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Screenshots

image

Checklist:

( * == Mandatory )

  • [x] * I have set myself as assignee of the pull request
  • [x] * My code follows the style guidelines of this project
  • [x] * Linting does not generate new warnings
  • [x] * I have performed a self-review of my own code
  • [x] * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • [ ] * I have commented my code, particularly in hard-to-understand areas
  • [ ] * I have put JSDoc comment in all required places
  • [x] * My changes generate no new warnings
  • [x] * I have included screenshots describing my changes if relevant
  • [ ] * I have selected labels in the Pull Request, according to the changes with code brings
  • [ ] I have made corresponding changes to the documentation ( if required )
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

TaiKamilla avatar Sep 04 '23 14:09 TaiKamilla

@Matthis-M-ReliefApps

It has been implemented in the frontend to maintain the route generic https://github.com/ReliefApplications/ems-frontend/pull/1792

NathanHGit avatar Mar 29 '24 15:03 NathanHGit

@Matthis-M-ReliefApps @MwanPygmay

I got some Axios errors when trying the feature, did you get some when testing on your side also?

AntoineRelief avatar Apr 25 '24 08:04 AntoineRelief

@AntoineRelief do you have the scope for common services?

MwanPygmay avatar Apr 25 '24 08:04 MwanPygmay

@AntoineRelief do you have the scope for common services?

@MwanPygmay Apart if it had changed, I think so yes

Doing the same request on Postman, I can get the data I can't from the code thus

AntoineRelief avatar Apr 25 '24 08:04 AntoineRelief

@AntoineRelief do you have the scope for common services?

@MwanPygmay Apart if it had changed, I think so yes

Doing the same request on Postman, I can get the data I can't from the code thus

I remember I also had some requests errors when I tried to start a review on it last week

Matthis-M-ReliefApps avatar Apr 25 '24 09:04 Matthis-M-ReliefApps

@Matthis-M-ReliefApps @MwanPygmay

looking at it again, I can see it's not yet complete:

  • history is not working fine
  • filtering in aggregations & layouts is not proposing any filter operator
  • export from resource is not working ( not the one from the grid, but from the resource page )

I can't merge it like that

AntoineRelief avatar Jun 26 '24 10:06 AntoineRelief