AB Email Notifications - Value Fix

[morgang-adappt]

Links

Base PR

Old PRs Old backend PR Old frontend PR

Related PR New frontend PR

In reference to this: https://github.com/ReliefApplications/ems-frontend/pull/2479#discussion_r1577632009

[AntoineRelief]

@HasnatL-Adapptlimited I can see you requested my review on this PR but also marked it as draft at the same time is it ready for review?

[AntoineRelief]

hi @HasnatL-Adapptlimited

to follow up on this one, if that can help you should certainly have a look at the ResourceExporter file in the back-end, as it contains quite a similar logic to what you're trying to achieve ( especially for choices fields ) you've certainly checked the existing files before coding the email feature, but just in case

in addition, for the front-end, it may help to simplify the logic by adding a simple endpoint in the back-end that would return the html of the email body to the front-end ( if that's doable ), instead of rebuilding a similar logic in the front-end, and creating potential differences between the sent email & the front-end preview it's a comment I would have kept for the phase 2, but I now prefer to put it now, in case you think that may help

[morgang-adappt]

Hi Antoine,

We have a few bugs remaining that are blocking the release on Saturday, and we are currently working to resolve these issues as a priority. Following the release, we will pick up this decision, and we can also discuss it further in tomorrow's catch-up call.

Thanks & Regards,

Morgan Gowans

Developer

E: @.@.>

W: adappt.aihttp://www.adappt.ai

[cid:3985b87a-aab4-42b0-ae77-dbdd85c4bf59]

---

From: Antoine Hurard @.> Sent: 20 May 2024 10:41 To: ReliefApplications/ems-backend @.> Cc: Morgan Gowans @.>; Author @.> Subject: Re: [ReliefApplications/ems-backend] AB Email Notifications - Value Fix (PR #1049)

hi @HasnatL-Adapptlimitedhttps://github.com/HasnatL-Adapptlimited

to follow up on this one, if that can help you should certainly have a look at the ResourceExporter file in the back-end, as it contains quite a similar logic to what you're trying to achieve ( especially for choices fields ) you've certainly checked the existing files before coding the email feature, but just in case

in addition, for the front-end, it may help to simplify the logic by adding a simple endpoint in the back-end that would return the html of the email body to the front-end ( if that's doable ), instead of rebuilding a similar logic in the front-end, and creating potential differences between the sent email & the front-end preview it's a comment I would have kept for the phase 2, but I now prefer to put it now, in case you think that may help

— Reply to this email directly, view it on GitHubhttps://github.com/ReliefApplications/ems-backend/pull/1049#issuecomment-2120073019, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BC7O6UKDYTDFEGJWVAT4DZLZDHAL3AVCNFSM6AAAAABHV6IBYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQGA3TGMBRHE. You are receiving this because you authored the thread.Message ID: @.***>