C2ME-fabric icon indicating copy to clipboard operation
C2ME-fabric copied to clipboard

Performance incompatibility with VS2

Open checkraisefold opened this issue 1 year ago • 2 comments

Describe the bug Serverside performance with C2ME and Valkyrien Skies 2 installed is heavily degraded. Disabling C2ME solves the issue. I haven't yet made a test-case server with only C2ME and VS2 installed, however the Spark profiler I ran seems to show that mixins (?) in chunk logic by C2ME cause some sort of bottleneck or persistent chunk unloading even when a vehicle is not actively being dismounted from in VS2.

Will attempt to make a test-case server with only C2ME and VS2 installed and latest devbuild soon, and this may boil down to being a issue that needs to be fixed by VS2 authors.

To Reproduce Steps to reproduce the behavior:

  1. Have Valkyrien Skies 2 and C2ME installed.
  2. Dismount from any VS2 vehicle (?)
  3. Server performance is heavily degraded until restart

Expected behavior Performance to not be degraded with these mods installed.

Screenshots

Runtime info (please complete the following information):

  • OS: Debian 12
  • Minecraft version: 1.20.1
  • Mod version: 0.2.0+alpha.11.0

Crash reports / logs https://spark.lucko.me/5kTqNAC4oX?hl=4855,5605,5643

Other mods Other mods are in the Spark profiler list (click mods in the top, full modpack)

Checklist

  • [x] I am using the official version of the mod.
  • [ ] I tried the latest development version but the issue persists.
  • [x] I searched for similar open issues and could not find an existing bug report on this.

checkraisefold avatar Feb 08 '24 04:02 checkraisefold

Try reproduce with a normal HotSpot JVM.

ishland avatar Feb 09 '24 16:02 ishland

HotSpot JVM

This was reproducible with the stock Debian repo Java (OpenJDK 17), and the performance was even worse without GraalVM EE's optimizations. Here's the profile I got before swapping to GraalVM: https://spark.lucko.me/Ciis3L2VFf?hl=1180,1531,1536

openjdk version "17.0.10" 2024-01-16
OpenJDK Runtime Environment (build 17.0.10+7-Debian-1deb12u1)
OpenJDK 64-Bit Server VM (build 17.0.10+7-Debian-1deb12u1, mixed mode, sharing)

As stated, I'll try and reproduce this on a server with just C2ME and VS2 pretty soon

checkraisefold avatar Feb 10 '24 01:02 checkraisefold