[Comment] Cross-Platform DevOps for .NET Core

[RehanSaeed]

https://rehansaeed.com/cross-platform-devops-net-core/

[RehanSaeed]

Matt F commented on 2017-05-02 11:27:00

It looks like there's a typo in your build.cake. You have:

var configuration = 
    HasArgument("Configuration") ? Argument("Configuration") :
    EnvironmentVariable("Configuration") != null ? EnvironmentVariable("BuildNumber") : "Release";

But I think it should be:

var configuration = 
    HasArgument("Configuration") ? Argument("Configuration") :
    EnvironmentVariable("Configuration") != null ? EnvironmentVariable("Configuration") : "Release";

[RehanSaeed]

Matt F commented on 2017-05-02 11:29:46

It looks like there's a typo in your build.cake. You have:

var configuration = 
    HasArgument("Configuration") ? Argument("Configuration") :
    EnvironmentVariable("Configuration") != null ? EnvironmentVariable("BuildNumber") : "Release";

But I think it should be:

var configuration = 
    HasArgument("Configuration") ? Argument("Configuration") :
    EnvironmentVariable("Configuration") != null ? EnvironmentVariable("Configuration") : "Release";

And another one:

// Find all crproj projects and build them using the build configuration specified as an argument.

Should be

// Find all csproj projects and build them using the build configuration specified as an argument.

[RehanSaeed]

Muhammad Rehan Saeed commented on 2017-05-05 14:36:50

It looks like there's a typo in your build.cake. You have:

var configuration = 
    HasArgument("Configuration") ? Argument("Configuration") :
    EnvironmentVariable("Configuration") != null ? EnvironmentVariable("BuildNumber") : "Release";

But I think it should be:

var configuration = 
    HasArgument("Configuration") ? Argument("Configuration") :
    EnvironmentVariable("Configuration") != null ? EnvironmentVariable("Configuration") : "Release";

Thanks, now fixed.

[RehanSaeed]

Muhammad Rehan Saeed commented on 2017-05-05 14:37:34

And another one:

// Find all crproj projects and build them using the build configuration specified as an argument.

Should be

// Find all csproj projects and build them using the build configuration specified as an argument.

Thanks again!