Frustration-One-Year-With-R
Frustration-One-Year-With-R copied to clipboard
Publish as a Quarto book
Fix #10 cc @krlmlr
One usually doesn't do PR from a default branch, but I wanted to be sure the GitHub Actions workflow worked. :sweat_smile:
You can see the result at https://maelle.github.io/Frustration-One-Year-With-R/
If you merge this, for the book to be deployed you'll need
- to check GitHub Actions workflow have read and write permissions (scroll down to "Workflow permissions" on https://github.com/ReeceGoding/Frustration-One-Year-With-R/settings/actions;
- after the first successful run of the workflow (that will have created the gh-pages branch) to indicate the gh-pages branch as source for the GitHub Pages website. https://github.com/ReeceGoding/Frustration-One-Year-With-R/settings/pages
Note that you have some content on R Markdown, that might need to be updated once the document exists as a Quarto book rather than "just" a Markdown README produced with R Markdown.
I broke the cross-references, let me fix them :sweat_smile:
Very interesting! I'm not quite sure what I'll do with this (I know virtually nothing about Quarto), but I'll take a closer look at some point and maybe do as you have suggested.
I think the indentation is slightly off. There are some code-blocks-followed-by-text inside bullet points. In the original, I was allowed to put the post-code text on the same level of indentation as the pre-code text. This version seems to always reset the indentation after the code block. Compare section 4.5.2 in both.
Very interesting! I'm not quite sure what I'll do with this (I know virtually nothing about Quarto), but I'll take a closer look at some point and maybe do as you have suggested.
No pressure, and feel free to ask any question about Quarto (note that I will be off the first three weeks of August, so don't be surprised if my answers are a bit delayed :innocent: )
I think the indentation is slightly off. There are some code-blocks-followed-by-text inside bullet points. In the original, I was allowed to put the post-code text on the same level of indentation as the pre-code text. This version seems to always reset the indentation after the code block. Compare section 4.5.2 in both.
Oh right! This happened only for indented code blocks with a blank line before them, probably because tinkr that I used for the transformation, so Commonmark under the block, considered the text after an item after a blank line to not be part of that list item. I made manual fixes, but please tell me if I missed some of them. I'm sorry about these small (or not so small) discrepancies.
Note that it seems fitting that it happens in the "what R does wrong" chapter, but I'm pretty sure it's a Commonmark issue, not an R issue. :smile_cat:
Hmm actually that indent fixing didn't work. :thinking:
all fixed now -- sorry about the flurry of commits.