redoc icon indicating copy to clipboard operation
redoc copied to clipboard

Add theme support to additional elements

Open Dianoga opened this issue 5 years ago • 6 comments
trafficstars

  • H2 and H3 now use theme.colors.primary.main
  • The right panel allows controlling
    • Selected tab background and text colors
    • Endpoint background and text colors
    • Endpoint server background and text colors

These are the only pieces I noticed as being especially problematic when trying to create a dark theme.

Dianoga avatar Jul 27 '20 15:07 Dianoga

The first commit contains the actual changes (I think I touched 4 files). The second is after running prettier.

Dianoga avatar Jul 27 '20 15:07 Dianoga

Hey, this looks great! Thanks!

So many changes caused by prettier. I think they changed the default value for arrowParens. Could you set it to avoid in package.json (https://github.com/Redocly/redoc/blob/master/package.json#L194) and rerun prettier again?

Thanks!

RomanHotsiy avatar Jul 28 '20 07:07 RomanHotsiy

@RomanHotsiy changed prettier as requested and ran again. Down to 11 files now 😄

Dianoga avatar Jul 28 '20 12:07 Dianoga

@RomanHotsiy is there anything else needed to get this merged?

Dianoga avatar Sep 16 '20 13:09 Dianoga

Thanks @Dianoga -- we'll be checking this out again soon. Thanks for your patience too.

adamaltman avatar Nov 08 '20 22:11 adamaltman

Is this still active?

It solves a lot of the customization problems that i am having.

thblckjkr avatar Nov 24 '20 18:11 thblckjkr

Thanks so much for building and sharing this with us. This pull request has been open a while, and I want to first apologise for that. We decided recently that this isn't a feature we're ready to adopt at this time - so I'll close this pull request, with thanks again for your input.

lornajane avatar Aug 22 '23 09:08 lornajane