redisai-py icon indicating copy to clipboard operation
redisai-py copied to clipboard

update type-hinting for parameters

Open Distortedlogic opened this issue 3 years ago • 5 comments

There are a lot of places where the typing is not proper, ie param: int = None instead of param: Optional[int] = None. This difference causes type checkers to complain user side when providing None directly or not providing any param to recieve the default None. I only fixed for user facing functions to be minimal.

Distortedlogic avatar Jan 16 '22 10:01 Distortedlogic

This pull request introduces 1 alert when merging cb5824843ec4cae2553ef94092fcf7bb8511f7d7 into 8686d02963c04545c59a13f137467df28aa47236 - view on LGTM.com

new alerts:

  • 1 for Unused import

lgtm-com[bot] avatar Mar 06 '22 14:03 lgtm-com[bot]

This pull request introduces 3 alerts when merging 7d98a07b427bd0b4f89a90d8443f131c83910544 into 8686d02963c04545c59a13f137467df28aa47236 - view on LGTM.com

new alerts:

  • 3 for Unused import

lgtm-com[bot] avatar Mar 08 '22 13:03 lgtm-com[bot]

This pull request introduces 1 alert when merging 7354f58c81ef802912b137337a8c8ad788ad93a4 into 8686d02963c04545c59a13f137467df28aa47236 - view on LGTM.com

new alerts:

  • 1 for Unused import

lgtm-com[bot] avatar Mar 08 '22 13:03 lgtm-com[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Mar 08 '22 13:03 sonarqubecloud[bot]

@Distortedlogic I don't know if you saw, given the noise in the status (sorry!). But test_numpy_sensor fails: https://app.circleci.com/pipelines/github/RedisAI/redisai-py/1087/workflows/cad0331e-f5b4-4ac8-94ed-205c98e71fcd/jobs/1927.

I approved the code, I thought it looked good.

chayim avatar Mar 24 '22 14:03 chayim