VectorSimilarity icon indicating copy to clipboard operation
VectorSimilarity copied to clipboard

Support Alpine 3.19

Open nafraf opened this issue 1 year ago • 1 comments

Support Alpine 3.19

Alpine 3.19 uses musl libc, it does not use glibc. During the compilation in Alpine 3.19, the project returns the following error because the types are not defined:

In file included from /w/VectorSimilarity/src/VecSim/vec_sim.h:16,
             	from /w/VectorSimilarity/src/VecSim/index_factories/tiered_factory.h:8,
             	from /w/VectorSimilarity/src/VecSim/index_factories/tiered_factory.cpp:7: 	 
/w/VectorSimilarity/src/VecSim/info_iterator.h:31:5: error: 'u_int64_t' does not name a type; did you mean 'uint64_t'?                                                                  	 
   31 | 	u_int64_t uintegerValue;       	// Unsigned value. Unsigned 64 buts integer.
      | 	^~~~~~~~~
      | 	uint64_t

This patch includes includes <sys/types.h> if GLIBC is not found

Which issues this PR fixes

  1. Required by MOD-7324 (RediSearch)

Mark if applicable

  • [ ] This PR introduces API changes
  • [ ] This PR introduces serialization changes

nafraf avatar Jul 24 '24 16:07 nafraf

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 24 '24 16:07 CLAassistant

Replaced by https://github.com/RedisAI/VectorSimilarity/pull/514

nafraf avatar Aug 05 '24 23:08 nafraf