FoundryVTT-BetterRolls5e icon indicating copy to clipboard operation
FoundryVTT-BetterRolls5e copied to clipboard

Request: Magic Items Support

Open baltaojp opened this issue 5 years ago • 4 comments

Hello! Your module is probably one of my must-have modules in my game just for the dual rolls option, to say nothing of the other features.

I was just wondering if there was any possibility of you adding support for Magic Items to Better Rolls 5e and figured this was probably the best way to reach you. That being said, should I be asking the developer of Magic Items instead?

baltaojp avatar Apr 14 '20 17:04 baltaojp

Sorry for the delay in response. I'll investigate it - haven't personally used the Magic Items module, so I'm unsure what sort of support I would need to provide yet.

RedReign avatar Apr 22 '20 22:04 RedReign

Thank you! Perhaps it would be worth getting in touch with the author of Magic Items and seeing what they have to say about it. If it would help at all, I could open a ticket with them?

baltaojp avatar Apr 25 '20 18:04 baltaojp

I see a recent update noted that Magic Items capability will be implemented in a future update. Any ETA for that? I love both modules and my players have recently expressed frustration that they can have both atm if they except that Better Rolls will be broken on items flagged as Magic Items.

DivertedCircle avatar Mar 07 '21 22:03 DivertedCircle

Magic Items currently works with Better Rolls, except that the rolls don't use Better Rolls (but at least they don't break)! The problem is that Magic Items needs to invoke Better Rolls, it can't be the other way around.

There's an update in the pipeline where I plan to override the roll() using libwrapper, and it should work completely then. However it'd break compatibility with a lot of modules, so I'm saving it for the 0.8 Foundry series.

CarlosFdez avatar Mar 08 '21 02:03 CarlosFdez