insights-core
insights-core copied to clipboard
feat(client): Get list of reports for system in more efficient way
All Pull Requests:
Check all that apply:
- [x] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
- [x] No Sensitive Data in this change?
- [ ] Is this PR to correct an issue?
- [x] Is this PR an enhancement?
Complete Description of Additions/Changes:
- Card ID: CCT-1082
To reduce the ammount of requests on Advisor API endpoint, checking for the latest results for a single host will happen only when there are some hits for that host. Also the permissions for /var/lib/insights were adjusted to 0o750 to align with the insights-client spec file.
Codecov Report
Attention: Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.
Project coverage is 77.63%. Comparing base (
1f49b61) to head (84ca637).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| insights/client/connection.py | 6.25% | 15 Missing :warning: |
| insights/client/__init__.py | 20.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #4459 +/- ##
==========================================
- Coverage 77.64% 77.63% -0.01%
==========================================
Files 745 745
Lines 41669 41676 +7
Branches 6696 6700 +4
==========================================
+ Hits 32354 32356 +2
- Misses 8285 8290 +5
Partials 1030 1030
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.62% <9.52%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Preliminary testing passed so everything looks fine from the QE side, verification comment has been left in the corresponding CCT card.
@xiangce we can merge this
Let's ignore the failed puptoo test in compatibility test this time. It's caused by this change to puptoo which requires some changes when preparing the venv for unit-test. Per my local test, this PR won't break the unit-test.