insights-core icon indicating copy to clipboard operation
insights-core copied to clipboard

feat: new datasources: host_key_files

Open shlao opened this issue 7 months ago • 2 comments

All Pull Requests:

Check all that apply:

  • [x] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • [x] No Sensitive Data in this change?
  • [ ] Is this PR to correct an issue?
  • [ ] Is this PR an enhancement?

Complete Description of Additions/Changes:

Add datasource to check why sshd couldn’t load host key.

shlao avatar Apr 06 '25 13:04 shlao

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.51%. Comparing base (77360f5) to head (156950e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4415   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files         744      745    +1     
  Lines       41585    41610   +25     
  Branches     8832     8837    +5     
=======================================
+ Hits        32233    32256   +23     
- Misses       8318     8320    +2     
  Partials     1034     1034           
Flag Coverage Δ
unittests 77.50% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 08 '25 03:04 codecov-commenter

@shlao as mentioned, we need to reconsider if it's worth adding this spec to core collection, do you have a Jira card to get this spec being approved first?

xiangce avatar Apr 08 '25 05:04 xiangce