insights-core
insights-core copied to clipboard
WIP: do not collect metadata stuff on client side
- "metadata" was already collected by core collection specs
- This change needs QE tests for all dependencies
- Jira: RHINENG-7581
Signed-off-by: Xiangce Liu [email protected]
All Pull Requests:
Check all that apply:
- [x] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
- [x] No Sensitive Data in this change?
- [ ] Is this PR to correct an issue?
- [ ] Is this PR an enhancement?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.22%. Comparing base (
aa673f9) to head (f0d73c8).
Additional details and impacted files
@@ Coverage Diff @@
## master #4250 +/- ##
==========================================
+ Coverage 77.18% 77.22% +0.04%
==========================================
Files 743 743
Lines 41451 41378 -73
Branches 8797 8788 -9
==========================================
- Hits 31994 31956 -38
+ Misses 8412 8376 -36
- Partials 1045 1046 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.21% <100.00%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can one of the admins verify this patch?
@m-horky - Would you mind taking a look at this PR when free? Thanks.
test me
ACK. I had to open RedHatInsights/insights-client#350, our tests assume the files are at archive's root, but that should be it.
Thanks a lot, @m-horky for your quick response and action on client package. We'll move it forward accordingly.
test me