insights-core
insights-core copied to clipboard
chore: Improve and simplify logging
All Pull Requests:
Check all that apply:
- [x] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
- [ ] Is this PR to correct an issue?
- [x] Is this PR an enhancement?
Complete Description of Additions/Changes:
- Card ID: CCT-705
This patch will help us with identifying what is happening at given times.
- Include phase, version and arguments on each phase load. Some of the information may not be necessary, as newer builds of insights-client contain logs that carry the information about phase and version. However, older builds do not, and these bits are valuable when debugging.
- Disable logging of HTTP responses for collection rules and Inventory host. They are verbose and do not need to be logged in a file every time. The important parts of it are logged elsewhere.
Hi @m-horky - Sorry for bringing this trouble to you, as we just resolved an urgent bug within the repo. Please rebase the master branch of your fork of insights-core and then rebase this branch again. Please reach out to me for any problems when doing the rebase. Apologize again.
Codecov Report
Attention: Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.
Project coverage is 77.16%. Comparing base (
0c0355f) to head (aefa1e2). Report is 1 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| insights/client/connection.py | 17.64% | 9 Missing and 5 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #4194 +/- ##
==========================================
- Coverage 77.18% 77.16% -0.02%
==========================================
Files 762 763 +1
Lines 41513 41540 +27
Branches 8773 8782 +9
==========================================
+ Hits 32042 32056 +14
- Misses 8413 8422 +9
- Partials 1058 1062 +4
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.15% <22.22%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
- Flaky Tests Detection - Detect and resolve failed and flaky tests
Also please wait for our QE ACK before merging. Thanks.
Can one of the admins verify this patch?
Hello @xiangce, it seems we're ready :)