insights-core icon indicating copy to clipboard operation
insights-core copied to clipboard

Add RHSM (Red Hat Subscription-Manager) Parser

Open lveyde opened this issue 5 years ago • 4 comments

Signed-off-by: Lev Veyde [email protected]

lveyde avatar Mar 10 '20 14:03 lveyde

Can one of the admins verify this patch?

jenkins-qa-bot avatar Mar 10 '20 14:03 jenkins-qa-bot

@lveyde - As you might notice, there is an existing parser YumRepoList which parses the output of yum -C --noplugins repolist command and can achieve the same function with this one.

https://github.com/RedHatInsights/insights-core/blob/900148134a25d4bbaed17455dd63171667dcc64d/insights/parsers/yum.py#L44

It's not suggested to add duplicated parsers. may I know the reason to add this spec and parser? Can the YumRepoList work for you?

xiangce avatar Mar 11 '20 02:03 xiangce

Hey,

The difference is that my parser takes the information directly from subscription-manager and thus allows to properly check the available RHN channels versus similarly named Yum repos, that may or may not include the expected packages.

We basically need to check that customers machine is properly configured as far as the RHN channels are concerned, and simply checking Yum doesn't provide that accuracy.

The attempt was made to use the same rule interface as the Yum parser, so that the rules could be easily modified to switch between parsers, if more strict or less strict check is required.

Thanks in advance, Lev Veyde,

On Wed, Mar 11, 2020 at 4:05 AM Xiangce Liu [email protected] wrote:

@lveyde https://github.com/lveyde - As you might notice, there is an existing parser YumRepoList https://github.com/RedHatInsights/insights-core/blob/900148134a25d4bbaed17455dd63171667dcc64d/insights/parsers/yum.py#L44 which parses the output of yum -C --noplugins repolist command and can achieve the same function with this one.

https://github.com/RedHatInsights/insights-core/blob/900148134a25d4bbaed17455dd63171667dcc64d/insights/parsers/yum.py#L44

It's not suggested to add duplicated parsers. may I know the reason to add this spec and parser? Can the YumRepoList work for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RedHatInsights/insights-core/pull/2491?email_source=notifications&email_token=AEUJRM3OSXBN2PXNBFEVKCTRG3WU5A5CNFSM4LFAK2N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEON3DXY#issuecomment-597406175, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEUJRM4LTJDB6NBZZ5CBNV3RG3WU5ANCNFSM4LFAK2NQ .

lveyde avatar Mar 11 '20 09:03 lveyde

@lveyde you will need to get this spec approved before we add the parser.

bfahr avatar Mar 24 '20 15:03 bfahr