FunnyAlgorithms icon indicating copy to clipboard operation
FunnyAlgorithms copied to clipboard

Shell Sort Algorithm implemented in JAVA

Open ShivamRajSingh opened this issue 3 years ago • 1 comments

ShivamRajSingh avatar Oct 02 '22 12:10 ShivamRajSingh

Hey Caio,

Glad you liked it. I'll add the comments. Can you please mark it as hactoberfest approved?

Regards

On Sun, Oct 2, 2022, 7:08 PM Caio Cordeiro @.***> wrote:

@.**** requested changes on this pull request.

What a great code 😄 ! Just a little tip, it's good always to put a description on your PRs to make it more understandable. Could you please add it for me? Thank you for contributing! 🚀

In sort/shell/ShellSort.java https://github.com/ReciHub/FunnyAlgorithms/pull/954#discussion_r985241156 :

  •    return 0;
    
  • }

  • public static void main(String args[])

  • {

  •    int arr[] = {12, 34, 54, 2, 3};
    
  •    System.out.println("Array before sorting");
    
  •    printArray(arr);
    
  •    ShellSort ob = new ShellSort();
    
  •    ob.sort(arr);
    
  •    System.out.println("Array after sorting");
    
  •    printArray(arr);
    
  • }

+}

Please add an empty line at the end of the file.

— Reply to this email directly, view it on GitHub https://github.com/ReciHub/FunnyAlgorithms/pull/954#pullrequestreview-1127646211, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALUTHGRVHPPC6HITUEAZ2HTWBGF47ANCNFSM6AAAAAAQ24FTAE . You are receiving this because you authored the thread.Message ID: @.***>

ShivamRajSingh avatar Oct 02 '22 13:10 ShivamRajSingh