FiltaQuilla icon indicating copy to clipboard operation
FiltaQuilla copied to clipboard

Filters causing a intermittent hang. (Thunderbird & Betterbird 128.3.3esr-bb14)

Open Mieekaserra opened this issue 1 year ago • 6 comments

Thunderbird & Betterbird 128.3.3esr-bb14 but have had same issues on older versions for the last month or so, that when checking for messages - thunderbird goes none responsive. The emails in question are from Yahoo - but dont appear to be in anyway special. The only way to stop the hang is to purge whichever mail is causing the overflow.

image

I managed to capture the above message from my error console right before it locked up.

Mieekaserra avatar Nov 06 '24 17:11 Mieekaserra

If you are using regular expression search in body, I am working one some fixes. Workaround for the regex is using the pattern /someRegex/g

check out latest versions posted here: https://github.com/RealRaven2000/FiltaQuilla/issues/269#issuecomment-2456029212

RealRaven2000 avatar Nov 06 '24 22:11 RealRaven2000

Workaround for the regex is using the pattern /someRegex/g

I assume the trailing g makes a difference? Just because I am curious, can I ask why this is a workaround?

smoelius avatar Dec 24 '24 11:12 smoelius

Workaround for the regex is using the pattern /someRegex/g

I assume the trailing g makes a difference? Just because I am curious, can I ask why this is a workaround?

IIRC: there used to be a bug caused by multiple matches (default switch for searching is /gm which caused an infinite loop, see:

https://github.com/RealRaven2000/FiltaQuilla/issues/269#issuecomment-2454620541

Adding your own switch /g undoes the multiple line switch, and thus only returns a single result, I think that's the nature of the workaround. But you shouldn't need it with the latest version of Filtaquilla -

The problem should be resolved by the latest release 4.3 - Published 17/11/2024 as I have rewritten the bodyMimeMatch function. Should we leave this bug open for information purposes, or close it as resolved?

RealRaven2000 avatar Dec 24 '24 14:12 RealRaven2000

The problem should be resolved by the latest release 4.3 - Published 17/11/2024 as I have rewritten the bodyMimeMatch function. Should we leave this bug open for information purposes, or close it as resolved?

I'll defer to @Mieekaserra.

I too had experienced hangs and disabled the extension. A few hours ago, I noticed the November update and re-enabled the extension. I have not experienced hangs during that time. (Though, it's a tiny window, of course.)


Aside: I use this extension to filter my GitHub notifications:

/pushed [0-9]+ commit(s)?/

And it's really convenient!

smoelius avatar Dec 24 '24 14:12 smoelius

I use this extension to filter my GitHub notifications:

/pushed [0-9]+ commit(s)?/

And it's really convenient!

👍👍

ok, looks good. I am not sure about using the "/" syntax at beginning and end, without any switches. My understanding is that Kent had programmed it to be either /regularExpression/switches or just expression (without slashes). You may have seen that I added a UI in the body regex terms, that separates the fields, which I intend to roll out to the other search terms that use regex:

image

I just need to adapt it to the other regex terms (such as subject) and remove the options that are body specific (such as process plaintext / exclude quotes etc.)

RealRaven2000 avatar Dec 24 '24 14:12 RealRaven2000

Thanks for the tips! :pray:

smoelius avatar Dec 24 '24 15:12 smoelius