react-native-mock icon indicating copy to clipboard operation
react-native-mock copied to clipboard

Missing support for percentage widths

Open fadookie opened this issue 8 years ago • 1 comments

React Native has recently added support for percentage widths.

Tests now fail props validation if a react-native-mock component is passed a percentage width string instead of a number:

Error: Warning: Failed prop type: Invalid prop `style.width` of type `string` supplied to `View`, expected `number`.

fadookie avatar May 24 '17 22:05 fadookie

Ooh, that's a nice improvement. I'm kinda suprised proptype failures cause tests to fail though, but hey it is an actual error i guess.

I plan to spend a large amount of time upgrading the project in the coming weeks, i'll make sure to add this to the list of things to check!

RealOrangeOne avatar May 25 '17 08:05 RealOrangeOne