Jake Howard

I actually think this might be a feature, not a bug (as the best bugs are). The change which broke my example is actually bf38e4dbd9e5ca2f002f901fad386d97c80b42ce. When the base image was...

Yes I think this can be closed. Some DX improvements around displaying the config file used would be nice, but that's pretty minor.

Whilst this fixes the case for `.update`, I think the issue would still happen with `.delete` (and other writing queryset APIs. I'd hope there's a more generic solution for this,...

This adds a (very slight) performance hit of needing to do `.scheme` on each iteration. Perhaps it would be better to rename the variables instead to `origin_scheme` instead? That way...

Django's policy for non-trivial changes is to open Trac tickets for discussion and review: https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/ > I'm not sure how best to test this reliably Testing that the keys are...

I think "trivial" here covers typos and small documentation changes. If in doubt, create a ticket.

@seanpar203 I'm not sure that's true - looking at the code in `master` it still tries to close connections even when unthreaded?

@carltongibson (as shepherd :sheep: ), what's the best way to get some Review Team eyeballs on this? Social media posting only gets the reviews so far.

I had a feeling a ticket might be the way forward. Opened ticket-35859. _Something something more content for the DEP talk_

Great comments @nessita. I should have time to implement them myself tomorrow