rxjs icon indicating copy to clipboard operation
rxjs copied to clipboard

GitHub Workflows security hardening

Open sashashura opened this issue 3 years ago • 2 comments

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

sashashura avatar Aug 29 '22 08:08 sashashura

Is there anyone else approve needed?

sashashura avatar Sep 20 '22 06:09 sashashura

No, Ben's approval is enough. He'll merge it once he finds enough time. The project is 100% based on voluntary work, please have understanding.

jakovljevic-mladen avatar Sep 20 '22 08:09 jakovljevic-mladen

Thank you, @sashashura

benlesh avatar Sep 25 '22 18:09 benlesh