rxjs
rxjs copied to clipboard
docs(exhaustAll): fix marble diagram
Description: This PR fixes exhaustAll marble diagram. Details described in #6909.
@timdp, the latest ghosts parameter feature works like a charm, thank you for the quick work on this one. If you publish non-alpha 0.18.1 version before this gets merged, I will update this PR.
Related issue (if exists): Fixes #6909
Thanks @mlegenhausen for reporting.
Cool! I'll probably release the stable version later today. The API will be identical.
Incidentally, you don't need the legacy swirly-* packages. I migrated everything to @swirly/* a while ago. I thought I'd also created a PR here but maybe something diverged.
Thanks @timdp.
Incidentally, you don't need the legacy
swirly-*packages. I migrated everything to@swirly/*a while ago.
I'm gonna removeswirly-parser, swirly-renderer-node and swirly-types packages in that case.
You can now upgrade to 0.18.1. I've also taken the liberty of adding your diagram to the repo as an example. 🙂
@jakovljevic-mladen ... can you rebase this? You can merge it after that.
@benlesh, since PRs like this one can be cherry-picked to the V7 branch, shall I do that?