rxjs icon indicating copy to clipboard operation
rxjs copied to clipboard

docs(exhaustAll): fix marble diagram

Open jakovljevic-mladen opened this issue 3 years ago • 3 comments

Description: This PR fixes exhaustAll marble diagram. Details described in #6909.

exhaustAll.svg

@timdp, the latest ghosts parameter feature works like a charm, thank you for the quick work on this one. If you publish non-alpha 0.18.1 version before this gets merged, I will update this PR.

Related issue (if exists): Fixes #6909

Thanks @mlegenhausen for reporting.

jakovljevic-mladen avatar May 31 '22 18:05 jakovljevic-mladen

Cool! I'll probably release the stable version later today. The API will be identical.

Incidentally, you don't need the legacy swirly-* packages. I migrated everything to @swirly/* a while ago. I thought I'd also created a PR here but maybe something diverged.

timdp avatar Jun 01 '22 06:06 timdp

Thanks @timdp.

Incidentally, you don't need the legacy swirly-* packages. I migrated everything to @swirly/* a while ago.

I'm gonna removeswirly-parser, swirly-renderer-node and swirly-types packages in that case.

jakovljevic-mladen avatar Jun 01 '22 07:06 jakovljevic-mladen

You can now upgrade to 0.18.1. I've also taken the liberty of adding your diagram to the repo as an example. 🙂

timdp avatar Jun 01 '22 07:06 timdp

@jakovljevic-mladen ... can you rebase this? You can merge it after that.

benlesh avatar Jan 24 '23 14:01 benlesh

@benlesh, since PRs like this one can be cherry-picked to the V7 branch, shall I do that?

jakovljevic-mladen avatar Jan 24 '23 15:01 jakovljevic-mladen