rxjs-docs icon indicating copy to clipboard operation
rxjs-docs copied to clipboard

docs(Observable): add documentation for interval

Open cschomer opened this issue 7 years ago • 6 comments
trafficstars

Add docs for operator : creation - interval

Close #80

cschomer avatar Mar 04 '18 18:03 cschomer

Could you change your commit messages. There are several :, these make travis break. If you need any help, just inform me. Thanks for your work!!!

niklas-wortmann avatar Mar 05 '18 19:03 niklas-wortmann

Yes sorry about that, should be corrected and passing now.

cschomer avatar Mar 06 '18 00:03 cschomer

Codecov Report

Merging #296 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         115      115           
  Lines         442      442           
  Branches       10       10           
=======================================
  Hits          400      400           
  Misses         40       40           
  Partials        2        2
Impacted Files Coverage Δ
src/operator-docs/creation/interval.ts 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2b103d...073aed5. Read the comment docs.

codecov-io avatar Mar 12 '18 23:03 codecov-io

@cschomer have time to make these changes yet? we'd love to merge!

ladyleet avatar Mar 14 '18 17:03 ladyleet

@ladyleet Hi I checked in 2 commits for the requested changes, are those not showing up? I think with those two that should address the two requested changes.

commit ea9c472d97e6c7b0f00feabc55bed642ab0781d1

cschomer avatar Mar 14 '18 23:03 cschomer

@cschomer - Thanks for the PR.

Please use Close #<issue-number> in your future commits in the description. This will auto-close the issue once the PR is merged in.

For this one, we can manually close the issue.

ashwin-sureshkumar avatar Mar 15 '18 13:03 ashwin-sureshkumar