rxjs-docs icon indicating copy to clipboard operation
rxjs-docs copied to clipboard

docs(operators): add fromPromise documentation

Open niklas-wortmann opened this issue 7 years ago • 7 comments

closes: #79

niklas-wortmann avatar Jan 04 '18 21:01 niklas-wortmann

Codecov Report

Merging #229 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         115      115           
  Lines         442      442           
  Branches       10       10           
=======================================
  Hits          400      400           
  Misses         40       40           
  Partials        2        2
Impacted Files Coverage Δ
src/operator-docs/creation/fromPromise.ts 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 192a02b...3266e74. Read the comment docs.

codecov-io avatar Jan 04 '18 21:01 codecov-io

@btroncone - Could you please re-review ?

ashwin-sureshkumar avatar Jan 25 '18 03:01 ashwin-sureshkumar

@ashwin-sureshkumar any idea why travis is broken? there is no log or something like that

niklas-wortmann avatar Jan 25 '18 06:01 niklas-wortmann

Its one of the dependencies @JWO719.

This PR fixes it https://github.com/ReactiveX/rxjs-docs/pull/236

Can you please review that PR, we have to have two approvals before we merge in. Then you can rebase with master and should be good.

ashwin-sureshkumar avatar Jan 25 '18 13:01 ashwin-sureshkumar

thx @JWO719 @ashwin-sureshkumar @btroncone for all your hard work!

ladyleet avatar Jan 25 '18 13:01 ladyleet

@btroncone @ashwin-sureshkumar last commit should fix both requested changes. Please take a look at it and let me know if there is something else I can fix.

niklas-wortmann avatar Feb 01 '18 20:02 niklas-wortmann

@btroncone, @ashwin-sureshkumar, @sumitarora could you take another look at this pr to get this done?

niklas-wortmann avatar Feb 06 '18 19:02 niklas-wortmann