RxPY icon indicating copy to clipboard operation
RxPY copied to clipboard

__eq__ implementation for Notification class

Open azhou95 opened this issue 3 years ago • 1 comments

The eq magic method for the Notification class seems to be implemented as a comparison of the two sides of the equality being casted to string.

This can lead to strange behaviour such as: OnNext(1.0) == OnNext("1.0") being evaluated as True.

Would it be possible to improve this behaviour?

azhou95 avatar Feb 11 '22 15:02 azhou95

You could try. Feel free to make a PR.

dbrattli avatar Feb 12 '22 10:02 dbrattli