RxJavaFX icon indicating copy to clipboard operation
RxJavaFX copied to clipboard

Published 20 hours ago • verified publisher icon ReactiveX

It looks like passing all the tests with openjfx 13.0.1

Open geniejhang opened this issue 5 years ago • 2 comments

Hi,

I tried to change openjfx version from 11 to 13.0.1 and it looks like compiled correctly, which means, as long as I understand, the library is not using any deprecated API.

Is there any reason not to update it to 2.13.0?

I'm just wondering since my projects are using openjfx 13.0.1.

Thanks for the fantastic library :)

geniejhang avatar Feb 24 '20 21:02 geniejhang

Hi @geniejhang, sorry for slow response. I've been busy with other endeavors this year.

This library needs to finish migration to RxJava 3 as well as OpenJFX so I'm glad to hear it checks out now.

Can you put in a PR or two to target OpenJFX and RxJava2 and/or RxJava3?

thomasnield avatar Mar 25 '20 17:03 thomasnield

Do you have any test in mind except for just changing the version number to the targets? What I tried is just to use it by changing the version number to 13.0.1 and 14 for OpenJFX. It also worked with JDK 13.0.2.

For RxJava, I thought by default it's with RxJava2. I've never tested with RxJava3, though.

If you don't have anything in mind, I can submit pull requests with changing version numbers.

geniejhang avatar Mar 30 '20 15:03 geniejhang