android-emulator-runner icon indicating copy to clipboard operation
android-emulator-runner copied to clipboard

fix: allow google_apis_ps16k as a valid target

Open mikehardy opened this issue 5 months ago • 1 comments

Hi there, we'd like to test using the new 16kb page size to make sure things work, but isn't working with the action here currently

As pointed out in the linked issue, it's a fairly trivial input validator change, so I thought I'd just propose a PR

Thanks!

  • Fixes #403

mikehardy avatar Jun 25 '25 16:06 mikehardy

Saw in related comment here https://github.com/ReactiveCircus/android-emulator-runner/pull/424#issuecomment-2602376051 that needed to add to test and do the transpile to JS, so just pushed that

mikehardy avatar Jun 25 '25 16:06 mikehardy

I addressed the thought on target validation with a redone implementation that removes validation but still allows (and tested) the playstore shorthand

I updated the docs related to target to reflect current reality of targets based on sdkmanager | sort | grep where I searched atd and ps16k to see what was available when and on what arch + channel

mikehardy avatar Jun 30 '25 15:06 mikehardy

I found the 'playstore' (and 'playstore_ps16k') shortcuts to be surprising personally, in all other cases you just use the actual target name but there are these two underdocumented shortcuts?

So I did update action.yml and README but I used the real sdkmanager target names so that people just get used to using those

I did not remove that feature though, I respect backwards-compability a lot more than that - just for documentation seems using the actual target names is more consistent

I pushed an updated second commit with the README.md and action.yml changes

what do you think?

mikehardy avatar Jul 01 '25 12:07 mikehardy

Looks good!

ychescale9 avatar Jul 01 '25 12:07 ychescale9

Can we have a tagged version with this change?

asfernandes avatar Sep 16 '25 00:09 asfernandes

@ychescale9 any chance of a release with this PR in it 🙏 ? I tried to integrate it into our CI via the commit SHA but it failed for an unexpected reason

mikehardy avatar Nov 06 '25 23:11 mikehardy

Sorry for the delay! Will try to do a release today.

ychescale9 avatar Nov 06 '25 23:11 ychescale9