RMG-Py
RMG-Py copied to clipboard
Transitory Edge Analysis
Adds transitory edge analysis species selection algorithm to RMG. RMS dual PR with https://github.com/ReactionMechanismGenerator/ReactionMechanismSimulator.jl/pull/196.
This pull request introduces 3 alerts when merging 3038f7973405aa4c123fa12f47825b7c132c510c into 2a35d62dc547ee21867bb9db2d10055a540cfe70 - view on LGTM.com
new alerts:
- 2 for Unreachable code
- 1 for Unused local variable
Codecov Report
Merging #2317 (6f1be0c) into main (2cdc2ea) will decrease coverage by
0.13%. The diff coverage is7.60%.
@@ Coverage Diff @@
## main #2317 +/- ##
==========================================
- Coverage 48.38% 48.25% -0.13%
==========================================
Files 110 110
Lines 30517 30605 +88
Branches 7951 7981 +30
==========================================
+ Hits 14765 14769 +4
- Misses 14211 14291 +80
- Partials 1541 1545 +4
| Impacted Files | Coverage Δ | |
|---|---|---|
| rmgpy/rmg/input.py | 27.27% <2.63%> (-2.01%) |
:arrow_down: |
| rmgpy/rmg/reactors.py | 19.95% <21.42%> (+0.20%) |
:arrow_up: |
| rmgpy/rmg/settings.py | 82.97% <100.00%> (+0.75%) |
:arrow_up: |
| arkane/encorr/decomp.py | 93.50% <0.00%> (-5.20%) |
:arrow_down: |
| arkane/kinetics.py | 12.24% <0.00%> (ø) |
|
| arkane/encorr/data.py | 93.48% <0.00%> (+0.93%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This pull request introduces 3 alerts when merging 3caf7807760cf6713d4d32772d9fad8798389436 into b2c917fd775c10e43bcb55805c9652ce05044532 - view on LGTM.com
new alerts:
- 2 for Unreachable code
- 1 for Unused local variable
This pull request introduces 3 alerts when merging cb0c64a359921f492cab62c97594f7bd431a6e6f into b2c917fd775c10e43bcb55805c9652ce05044532 - view on LGTM.com
new alerts:
- 2 for Unreachable code
- 1 for Unused local variable
@hwpang https://github.com/ReactionMechanismGenerator/ReactionMechanismSimulator.jl/pull/196 is merged now. I think we're ready here, can you approve?