ReVanced
bug (YouTube): `Hide info panels` hides panel that should not be hidden
Bug description
App/Patches info
App: YouTube v19.11.43 Patches: v4.8.2
Bug details
The Hide info panels option (found in Settings > ReVanced > Player) also hides the following section on the page that appears when you search about "suicide".
Why this is a bug
This panel should not be hidden for 2 reasons:
-
The
Hide info panelsoption is found in the Player settings, so it should only hide panels in the player. -
When the panel (shown above) is hidden, it is impossible to view the search results. So by hiding it, it is only an annoyance rather than a useful feature. At the very least, there should be a warning about this downside in the toggle description.
Error logs
No response
Solution
No response
Additional context
No response
Acknowledgements
- [X] This issue is not a duplicate of an existing bug report.
- [X] I have chosen an appropriate title.
- [X] All requested information has been provided properly.
Does this issue still show up? I cannot reproduce it (it never shows the "you are not alone" warning).
The issue still occurs on YT 19.16.39 with patches v4.13.3
I'm guessing the warning only appears in countries where there that suicide hotline functions
I was able to reproduce it on a different account.
It appears filtering just |information_panel.eml hides 2019 disease warnings, and the 'show anyways' is not hidden as desired.
The | is needed for the filter to not hide single_item_information_panel.eml (which incorrectly hides the 'show anyways' button).
Not sure if this change works for other usage of info panel, because these two use cases are all I can find where it pops up.
This setting should also be moved to General since it shows up in the feed and in the player.
Edit: some additional filters are needed to hide some components that are no longer filtered, such as publisher_transparency_panel.eml. there is likely additional unidentified components as well.
@KobeW50 It's just a test code but...try it anyway:
Define a variable outside method:
private static int frictionPanelState = 0;
Add the following in the method instead:
//---------------------------------Friction Panel------------------------------------//
if (combinedTemplates.contains("cell_divider")) {
frictionPanelState = 1;
} else if (combinedTemplates.contains("single_item_information_panel")) {
if (frictionPanelState == 1) {
frictionPanelState = 2;
}
return frictionPanelState == 2;
} else if (!combinedTemplates.contains("null") &&
!combinedTemplates.contains("search_friction")) {
frictionPanelState = 0;
}
//-----------------------------------------------------------------------------------//
It's just a test code but...try it anyway:
Due to time contraints and lack of knowledge I'm unable to make my own patches to test with. Thank you for your efforts. Sorry
It's just a test code but...try it anyway:
Due to time contraints and lack of knowledge I'm unable to make my own patches to test with. Thank you for your efforts. Sorry
It works on my side anyway...
This is how it appears in the search view
I was able to reproduce only once then not again. It should be fixed with https://github.com/ReVanced/revanced-patches/commit/4ac8854b99808a8957f3b0b7438e1e0cdedffbaf but I cannot completely confirm.