revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

bug: TikTok can't be patched

Open jay5656 opened this issue 2 years ago • 13 comments

Type

Error at runtime

Bug description

TikTok just won't patch, I don't know how to fix this

Steps to reproduce

Step1: select TikTok

Step2: Select any patch

Step3: Click patch button

Android version

Android 12

Manager version

0.0.51

Target package name

com.zhiliaoapp.musically

Target package version.

27.3.4

Installation type

Non-root

Patches selected.

Feed filter Playback speed Show seekbar

Device logs (exported using Manager settings).

(unsure how to do this )

Installer logs (exported using Installer menu option) [unneeded if issue is not during patching].

No response

Screenshots or videos

Screenshot_20221216-233019

Solution

No response

Additional context

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • [X] I have written a short but informative title.
  • [X] I filled out all of the requested information in this issue properly.
  • [X] The issue is related solely to the ReVanced Manager

jay5656 avatar Dec 17 '22 04:12 jay5656

I would upload a log file but GitHub is refusing to accept my file, despite it being a log file.

jay5656 avatar Dec 17 '22 06:12 jay5656

It is happening on both Revanced Manager and Revanced CLI.

gotham8x avatar Dec 17 '22 08:12 gotham8x

Having same issue on my Pixel 7 Pro, running Android 13, Magisk Canary 25205. Manager version 0.0.52.

bikram-agarwal avatar Dec 21 '22 14:12 bikram-agarwal

Having same issue on my Pixel 7 Pro, running Android 13, Magisk Canary 25205. Manager version 0.0.52.

Exactly same everything here except I don't use Magisk, also have issue

Minikiin avatar Dec 21 '22 19:12 Minikiin

This seems to be the case with everyone. It will be fixed in time. Just gotta be patient. Y'all have to remember... Revanced brought "vanced" back to life. They didn't have to revive it but they did. So we need to appreciate them as mich as we can, anyway we can. That means by being patient and they will send out an uodate soon....I think. Unless I'm talking outra my arse!

J4k-The-Reaper avatar Dec 21 '22 20:12 J4k-The-Reaper

This seems to be the case with everyone. It will be fixed in time. Just gotta be patient. Y'all have to remember... Revanced brought "vanced" back to life. They didn't have to revive it but they did. So we need to appreciate them as mich as we can, anyway we can. That means by being patient and they will send out an uodate soon....I think. Unless I'm talking outra my arse!

I don't think anyone is complaining / bitching. Submitting bugs / issues IS the very purpose of this "issues" page.

Btw, admins, why is every comment getting marked as spam here? Are we not supposed to add our comment with device / config details if we have same issue?

bikram-agarwal avatar Dec 21 '22 20:12 bikram-agarwal

Because they believe that it's effectively the same as a +1, I'd assume.

Poopooracoocoo avatar Dec 22 '22 02:12 Poopooracoocoo

Because they believe that it's effectively the same as a +1, I'd assume.

If the comments are just "me too. fix it", then sure; that adds nothing to the discussion. But if others are commenting that along with their device model, OS version, app version etc, then those are valuable data points; proving that issue is not caused by whatever combo OP is using. Original post from issue reporter is for one particular device, one particular OS version. When others comment with a different device-OS-app version combo, that can mean that "ok, it's not just that device's issue", or "not just that OS version issue", or "not just that app version issue" etc.

But seeing as the admins don't want such data, and think that's spam, I'll stop coming to this repo and just follow the subreddit.

bikram-agarwal avatar Dec 22 '22 06:12 bikram-agarwal

I'm also having the same issue, on my Note10+, android 12.

I'm running RevancedManager v 0.0.52, I've tried with Tiktok 27.8.2, 27.8.3, 27.8.4

I can patch other apps without issue. I've tried different patch combinations already as well. revanced-manager_logcat_20230115235223148637.log

echo-lalia avatar Jan 16 '23 07:01 echo-lalia

@bagarwa Adding irrelevant information is not a free ticket to say "me too". If said information were relevant, it would be a required field in the issue template. Because it is not, it adds nothing more than "me too" as you described it. For that reason, it is marked as spam to keep the issue with relevant information.

oSumAtrIX avatar Jan 16 '23 10:01 oSumAtrIX

@bagarwa Adding irrelevant information is not a free ticket to say "me too". If said information were relevant, it would be a required field in the issue template.

Lol, the irony. The info I provided in my original comment - those ARE required field in issue template. "Android version", "manager version", "installation type". @oSumAtrIX You can read, right? Value of all 3 in my comment are different than what OP gave. So it's NOT a plain "me too".

bikram-agarwal avatar Jan 16 '23 17:01 bikram-agarwal

It is not a ReVanced Manager issue. It is a patches issue and the patches issue template does not have the fields.

oSumAtrIX avatar Jan 16 '23 17:01 oSumAtrIX

This isn't a manager issue right? So shouldn't this issue be marked as closed?