revanced-manager icon indicating copy to clipboard operation
revanced-manager copied to clipboard

feat: Add a Dynamic Dark theme

Open lopez05656 opened this issue 3 years ago • 2 comments

Type

Cosmetic

Manager Branch

Flutter

Issue

ReVanced Manager's Dark theme doesn't respect my phone's dark theme settings and has to be set manually within the app.

Feature

Replace the Dark Theme toggle with a dialog that has these 3 options: Light Theme Dark Theme System Theme (Should be the default option)

Motivation

If this feature is considered, it'll prevent people from blinding themselves when they open the ReVanced Manager at night and it'll also respect your Phone's dark theme settings as an added bonus.

Additional context

No response

lopez05656 avatar Sep 22 '22 17:09 lopez05656

Manager already does this by default. The first time it is opened, it uses system theme brightness to set dark mode or not. Which version of the Manager you are using?

ponces avatar Sep 23 '22 14:09 ponces

I'm Using 0.0.22. But what I'm saying here is the app shouldn't just respect it on the first launch. It should respect it even after the first launch and it should be more customizable, like with a dialog. For example, Google Calculator shows a "Choose Theme" dialog. If you choose "Light Theme", the app will use a Light Theme. If you choose "Dark Theme", it'll use the app's Dark Theme. If you choose "System Theme", it'll respect your Phone's dark theme settings. You should add something similar to that in the ReVanced Manager.

lopez05656 avatar Sep 23 '22 16:09 lopez05656

Closing this in favour of #923