revanced-manager
revanced-manager copied to clipboard
ReVanced
feat: When trying to patch a bundled/split apk the manager should refuse to patch with a message
Type
Functionality
Manager Branch
Flutter
Issue
Bundle apk files don't work. I confirmed through testing and found the notice isn't helpful and should be reworked.
Feature
The manager should deny patching the apk with a message saying: "Bundle APK's are not supported. Make sure the apk you download is not a bundle. apkmirror.com is a good source of apk files and clearly states if the file you download is a bundle or not"
Motivation
It clears up confusion i've noticed on reddit especially. Someone on r/revancedapp asked me how to find the correct apk.
Additional context
No response
Split apks do work but only for root. And we can not add apkmirror as source as it's third party.
And we can not add apkmirror as source as it's third party.
Just an after thought inspired by this issue but, can we add a button with a customizable url to open next to each apps' update available panel? Or something?
Split apks do work but only for root. And we can not add apkmirror as source as it's third party.
What about making it so that the app mentions split apk's require root to patch and have it stop patching with an error saying "root not detected - split apk unable to be patched. Verify you have a non-bundled apk to patch with non-root"
I second this. Actually many people got confused when they patched over bundled APK but they force quit upon launch. That's a very odd UX because they won't directly learn which step is wrong before consulting at GitHub or discord.
Btw, I got insulted when bring up and discussing this suggestion at discord.
"root not detected - split apk unable to be patched. Verify you have a non-bundled apk to patch with non-root"
Thing is we check root when they click on install as root. This helps to mount only individual apps while non root for others.
"root not detected - split apk unable to be patched. Verify you have a non-bundled apk to patch with non-root"
Thing is we check root when they click on install as root.
Yea after they spent several minutes patching the apk lol.
Yea after they spent several minutes patching the apk lol.
There is no other way though. We can't have a universal settings toggle because you would have to change settings for every app. But i want to reimplement it inspired by the above issue.
Hm actually what if there's a change where the root check is done when enabling an option in settings called "Use root access" and if the option isn't checked the install with root option is hidden after patch completed and a message is shown saying "Root access is required to patch bundled apk files. Download another apk file that is not bundled" Also the setting would be global so it'll affect all apps this manager supports.
Please give some love to this issue :)) I ignored the warning prompt, my apps started crashing... but turns out it should've been a strict error prompt for nonroot.
