revanced-api icon indicating copy to clipboard operation
revanced-api copied to clipboard

chore: Use Kotlin for ReVanced API

Open oSumAtrIX opened this issue 1 year ago • 2 comments

About

This PR rewrites this project into Kotlin. Ktor is used for the API.

Todo before merge

  • [ ] Add issue templates
  • [ ] Setup repository tags correctly (proper naming for example)

Review

  • [ ] All the routes work, and none are missing
    • [ ] Caching is done correctly
    • [ ] Headers are set correctly
    • [ ] Auth works correctly
    • [ ] Cors works correctly
  • [ ] Persistence layer is correctly implemented
  • [ ] Rate limits are not an issue
  • [ ] Dockerfile and Docker Compose are setup correctly
  • [ ] CI/CD works properly
    • [ ] Version is bumped correctly
    • [ ] Pre-releases are built and published correctly, also to the Docker registry
    • [ ] Release assets are uploaded, and the changelog is generated correctly
    • [ ] Release workflow should probably not run outside of dev or main

oSumAtrIX avatar Feb 01 '24 03:02 oSumAtrIX

What is the motivation to rewrite it in kotlin?

indrastorms avatar Feb 01 '24 12:02 indrastorms

Personally, it makes it easier for me to maintain and reduces the amount of languages as we already use Kotlin. With our current maintainer being short on time, especially in the future, the Kotlin version will be easier to look into for me or other Kotlin devs we have

oSumAtrIX avatar Feb 01 '24 12:02 oSumAtrIX

@alexandreteles I don't know the exact conditions for caching, headers and cors so it would be good if you can check if those are setup correctly.

oSumAtrIX avatar Jun 05 '24 15:06 oSumAtrIX