dockerregistrypusher icon indicating copy to clipboard operation
dockerregistrypusher copied to clipboard

Published 20 hours ago • verified publisher icon Razikus

fix bug) set digest by params to concat original query string in uploadUrl and digest

Open tsbkw opened this issue 3 years ago • 0 comments

chunkedUpload failed when uploadUrl (which is specified by registry server) does not contain query string parameter.

When uploadUrl does not contain query string, adding digest in query string should be like + '?digest=, because digest is first query string parameter. To make it easy to handling parameter, use params of requests. It preserve original query string in url as shown in below.

  • https://github.com/psf/requests/blob/5e749546a26ce62e53d0a14ae1455f8b066fe19f/requests/models.py#L390
  • https://github.com/psf/requests/blob/5e749546a26ce62e53d0a14ae1455f8b066fe19f/requests/models.py#L445

tsbkw avatar Feb 23 '22 03:02 tsbkw