raytracing.github.io
raytracing.github.io copied to clipboard
RayTracing
Main Web Site (Online Books)
It seems like the incoming ray is not used in any of the calculations of the scattering_pdf member functions. Although there is no error nor negative side-effects, this parameter could...
Move the gamma function--which is currently a square root--into it's own distinct function. Simultaneously, consider correcting to a bt709 function in book 1 or 2
What would you think about something like the following? ``` auto sample_color = ray_color(scattered, depth-1); auto scattering_pdf = rec.mat->scattering_pdf(r, rec, scattered); color scattered_color = (srec.attenuation * scattering_pdf * sample_color) /...
Telling whether a random image employs linear or sRGB color values is usually a hard task. However, linear space is certainly the rarest. In the more common case that the...
The text around the correct cos(𝜙) distribution is confusing. Sections 8.6 "An Alternative Diffuse Formulation" and 8.5 "True Lambertian Reflection" both seem to me to be correcting Section 8.1 "A...
... > In think that when implementing recursive bouncing for the first time, sampling a direction uniformly is one of the first things to try. This is actually how I...
Multiple strategies to sample a new bouncing direction are given in book 1. It is also said that the resulting renders differ, suggesting that's expected, but the it isn't. Indeed,...
the Cornell box has dimensions of 0, 213, 343, 55 Consider changing the whole thing to be within a 0.0 - 1.0 unit cube. This would actually be a significant...
In https://github.com/RayTracing/raytracing.github.io/commit/44717c5e6f7048f0a11c069f35ac64530d9fa2c5#diff-07a8e2f6f94449c02a84af2decab2819d20e1d24e694d4327e40fad7ac2c0fccL2542 the size of the inner glass sphere was changed from `-0.45` to `-0.4`. In my renders locally this makes the generated image not match what is presented in...
Rendering time in a single-threaded C++ implementation becomes an issue when getting to the larger examples and when trying to render with many samples per pixel, in particular, before doing...
