raspap-docker icon indicating copy to clipboard operation
raspap-docker copied to clipboard

fix: rpi-compatible Docker images

Open ezhil56x opened this issue 1 year ago • 17 comments
trafficstars

Issue

Fixes #18 /claim #18

Description

  • Added support for debian based systems
  • Works on bookworm and github.repo:bullseye
  • Made required changes to build_docker_image.yml
  • When there is a push on master branch jrcichra/raspap-docker:bookworm and jrcichra/raspap-docker:bullseye docker images are built and pushed to the repository
  • Made required changes on README.md

Tested on Raspberry Pi 3 Model B+ with Raspberry Pi OS bookworm and Raspberry Pi OS bullseye

ezhil56x avatar Dec 28 '23 06:12 ezhil56x

@ezhil56x I'm traveling today and will check your PR in the next 24hrs, thanks

billz avatar Dec 28 '23 19:12 billz

@jrcichra mind checking this PR? thanks :)

billz avatar Dec 31 '23 15:12 billz

@billz @jrcichra

I have completed everything. Can you review once and if some changes are required, happy to do!

ezhil56x avatar Dec 31 '23 17:12 ezhil56x

@billz Any update?

ezhil56x avatar Jan 01 '24 18:01 ezhil56x

I'll be free to test the containers tomorrow.

jrcichra avatar Jan 01 '24 18:01 jrcichra

Earlier due to ro there was an issue, so I have changed it to rw and when the setup file runs as root it is creating some issue while installing and configuring raspap. So added user to the dockerfile

ezhil56x avatar Jan 01 '24 18:01 ezhil56x

I tested the bookworm version by building it with this: docker build -t ghcr.io/raspap/raspap-docker:bookworm -f Dockerfile.deb12 . and running with this: docker run --name raspap -it -d --privileged --network=host --cgroupns host -v /sys/fs/cgroup:/sys/fs/cgroup:rw --cap-add SYS_ADMIN ghcr.io/raspap/raspap-docker:bookworm

Then following the steps of making a user and installing raspap, then restarting the container. That all worked.

I was able to connect to the AP but couldn't get internet until I did the step @billz mentioned here: https://github.com/RaspAP/raspap-docker/pull/20#issuecomment-1873366463

Then I connected and it worked. I could do a speedtest.net on my phone.

I tried restarting the AP without WPA. That required me to restart the docker container + reapply the iptables rules for it to work. So it's functional but has some rough edges we can iron out over time.

jrcichra avatar Jan 02 '24 16:01 jrcichra

not to sh!t on other claimants but why the whole change in the workflow and the two seperate containers? as stated in https://github.com/RaspAP/raspap-docker/issues/11#issuecomment-1103108806 this is not the problem of raspap, but of docker, so i honestly don't get all the changes...

NL-TCH avatar Jan 02 '24 17:01 NL-TCH

not to sh!t on other claimants but why the whole change in the workflow and the two seperate containers? as stated in https://github.com/RaspAP/raspap-docker/issues/11#issuecomment-1103108806 this is not the problem of raspap, but of docker, so i honestly don't get all the changes...

The base image differs for each container to work correctly.

ezhil56x avatar Jan 03 '24 15:01 ezhil56x

@jrcichra Does this PR require any change or is this ready to merge?

ezhil56x avatar Jan 03 '24 20:01 ezhil56x

@billz @jrcichra Any update or changes required?

ezhil56x avatar Jan 04 '24 13:01 ezhil56x

@ezhil56x I was traveling the last 48hrs. Will do more testing with both PRs and revert back with any change requests. thanks!

billz avatar Jan 04 '24 15:01 billz

@billz Any update?

ezhil56x avatar Jan 06 '24 04:01 ezhil56x

hey @jrcichra,

I tried restarting the AP without WPA. That required me to restart the docker container + reapply the iptables rules for it to work. So it's functional but has some rough edges we can iron out over time.

I don't have this issue while using the changes in #20 and #21 . When i reboot and stop-start the container, the firewall rules are still there. can you verify if using these PR's fixes the issue?

NL-TCH avatar Jan 06 '24 16:01 NL-TCH

@billz @jrcichra Any update?

ezhil56x avatar Jan 07 '24 06:01 ezhil56x

@billz I have bumped the version that fixes the issue and added good practices 7 days back. Not sure why this PR wasn't selected 😞

ezhil56x avatar Jan 07 '24 20:01 ezhil56x

I'm approaching this as an end-user, not a Docker pro, and generally finding it more difficult to use this PR. The majority of RaspAP users, I believe, want as little friction as possible getting a container running. In the interest of simplifying things, we've also decided to drop Debian 11 support.

There are still issues with the docker image build and ghcr.io, so we may create a separate bounty for this.

billz avatar Jan 08 '24 08:01 billz