rasa icon indicating copy to clipboard operation
rasa copied to clipboard

ISSUE-11389 - Add retrieve_full_tracker to FailSafeTrackerStore

Open fliak opened this issue 3 years ago • 2 comments

Proposed changes:

  • Add method retrieve_full_tracker to avoid hiding ability of fetching full message history

Status (please check what you already did):

  • [ ] added some tests for the functionality
  • [ ] updated the documentation
  • [ ] updated the changelog (please check changelog for instructions)
  • [ ] reformat files using black (please check Readme for instructions)

fliak avatar Jul 28 '22 05:07 fliak

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


George Novik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 28 '22 05:07 CLAassistant

Hi @fliak, thanks for your contribution if you'd still like to merge this PR could you please sign the CLA agreement? Also in order to merge this PR we need to fix the Code Quality fail which is currently complaining about rasa/core/tracker_store.py:1277:68: F821 undefined name 'sender_id', could you also please fix the issue?

sanchariGr avatar Sep 21 '22 10:09 sanchariGr

@fliak The retrieve_full_tracker method was added to FailSafeTrackerStore as of version 3.5.2, you can see the code on main branch as well: https://github.com/RasaHQ/rasa/blob/main/rasa/core/tracker_store.py#L1462 Closing this PR.

ancalita avatar Apr 21 '23 13:04 ancalita