lumberjack-core icon indicating copy to clipboard operation
lumberjack-core copied to clipboard

Published 20 hours ago • verified publisher icon Rareloop

Constant ASC is used one level lower than defined

Open szepeviktor opened this issue 5 years ago • 3 comments

Used in Contracts\QueryBuilder interface, defined in QueryBuilder

How could that be fixed?

szepeviktor avatar Oct 28 '20 00:10 szepeviktor

@szepeviktor good spot, any suggestions?

joelambert avatar Oct 01 '21 16:10 joelambert

@joelambert I don't dare to say software design in a GitHub issue. Sorry.

szepeviktor avatar Oct 01 '21 16:10 szepeviktor

I may do more harm than good. Maybe an interface should not have default values for parameters.

szepeviktor avatar Oct 01 '21 16:10 szepeviktor