ecommerce icon indicating copy to clipboard operation
ecommerce copied to clipboard

Published 20 hours ago • verified publisher icon RailsEventStore

Hanami integration

Open swilgosz opened this issue 3 years ago • 3 comments
trafficstars

Overview

Integration of Ecommerce with Hanami 2 application.

The code includes the hanami 2 initial app files, so it can be a bit hard to review all. This is why for now I only integrated CRM BC as it seemed to be the smallest one.

Design

  • Create a slice per BC.
  • Instead of using global configuration forcing to enable all BCs at once, create config within each BC.

Dev notes

To review PR without initial Hanami 2 app files, here is the comparison skipping initial commits.: https://github.com/swilgosz/ecommerce/compare/9afec8f4aa7c102935c12554c226eb162f993640...swilgosz:hanami-integration

Caevats.

  1. I have found some active support dependencies issues I needed to tweak.
  2. For some reason, when I configured ROM adapter, I ended up with an Sequel Error in RES-ROM and opened a quick-fix PR for it https://github.com/RailsEventStore/rails_event_store/pull/1297

swilgosz avatar Apr 05 '22 21:04 swilgosz

I have been recently wondering what is the status of this initiative. Almost 3 years later Hanami is much more complete framework, includes persistence etc. Most of code specific to RES/ecommerce will likely still work without changes, but the base Hanami app would look differently (for example, using eslint instead of webpack). Would it make sense to create a new PR with empty Hanami 2.2 app and apply the commits from this branch on top?

katafrakt avatar Mar 17 '25 18:03 katafrakt

It would be nice to see it working with the new Hanami. I dont know enough about its internals to suggest which way to go. My gut feeling is to start from scratch.

andrzejkrzywda avatar Mar 17 '25 19:03 andrzejkrzywda

In that period I also gained much more expertise on Hanami, I will re-add this to my schedule for next month, would that work for you?

swilgosz avatar Mar 18 '25 12:03 swilgosz

Hey @swilgosz, sorry if it feels pushy. I just wanted to check if this is still something on your roadmap. Asking because I might have some extra time in the near future and Hanami integration could be one of the things to spend it on. But I definitely don't want to duplicate efforts or dismiss your work, of you still have your eyes on this.

katafrakt avatar Sep 28 '25 17:09 katafrakt

Hey, thanks for mentioning this. Unfortunately, this completely slipped-off of my mind.

I will appreciate if you can just check it off, but let me know if you can't. I hate leaving things unfinished, so may take care of it just to stay sane.

Let's stay in contact 🙏

swilgosz avatar Sep 28 '25 19:09 swilgosz