RecBole icon indicating copy to clipboard operation
RecBole copied to clipboard

[💡SUG] Avoid running epochs for models that require no optimization.

Open lukas-wegmeth opened this issue 1 year ago • 2 comments
trafficstars

Is your feature request related to a problem? Please describe. Some models, e.g., ItemKNN and ADMMSLIM, require no "training" after initialization. That is, their forward functions are empty, and calculate_loss always returns 0. However, by setting epochs in the config, these models can be "trained" for many epochs, even though nothing will change in the model itself.

Describe the solution you'd like Printing a warning or ignoring the epochs config setting for these models would be helpful. This also makes it clear to the user that the model they train does not require update steps past initialization.

lukas-wegmeth avatar Mar 06 '24 08:03 lukas-wegmeth

@lukas-wegmeth Thanks for your suggestions! We will improve it in the next development plan.

BishopLiu avatar Mar 10 '24 04:03 BishopLiu

@BishopLiu Thanks for considering my suggestion. Feel free to close this issue at will.

lukas-wegmeth avatar Mar 14 '24 12:03 lukas-wegmeth