rt-thread icon indicating copy to clipboard operation
rt-thread copied to clipboard

[Bug] FAL头文件可能会污染ulog

Open kaidegit opened this issue 1 year ago • 3 comments

RT-Thread Version

master

Hardware Type/Architectures

h750

Develop Toolchain

GCC

Describe the bug

引入或间接引入会导致log_d等api受到污染

在程序中定义LOG_TAG后引入ulog后再引入fal,或是先引入fal再定义LOG_TAG引入ulog,均会导致log_d等小写api使用FAL的log

image image image

Other additional context

No response

kaidegit avatar Aug 07 '24 00:08 kaidegit

调换一下顺序,这一块放到最后

#define LOG_TAG              "example"
#define LOG_LVL              LOG_LVL_DBG
#include <ulog.h>

wdfk-prog avatar Aug 07 '24 01:08 wdfk-prog

唔似乎要求在包含fal之前的头文件都没有包含过ulog,否则最下面的包含ulog直接就被忽略了,也不是很友好。比如我这个

#include "spi_flash_sfud.h"
#include "flashdb.h"

就会导致还是ulog先引入,并且略难排查

kaidegit avatar Aug 07 '24 01:08 kaidegit

或者这类是否有好的解决办法,大家可以多想想

BernardXiong avatar Aug 08 '24 06:08 BernardXiong

https://github.com/RT-Thread/rt-thread/pull/9690

mysterywolf avatar Nov 24 '24 03:11 mysterywolf