rocFFT icon indicating copy to clipboard operation
rocFFT copied to clipboard

Published 20 hours ago • verified publisher icon ROCm

Add CMake for documentation

Open matyas-streamhpc opened this issue 2 years ago • 6 comments

Summary of proposed changes: Add CMake support for documentation.

matyas-streamhpc avatar Nov 21 '23 14:11 matyas-streamhpc

@feizheng10 @malcolmroberts Can I get a review for this PR?

saadrahim avatar Nov 28 '23 14:11 saadrahim

The general idea here is definitely good - when I think ahead to wanting to making a similar change for all math libs, I'm wondering whether at least some of this should be moved into rocm-cmake so it doesn't have to be redone for each library.

The root CMakeLists.txt also is prepared to fetch rocm-cmake, so doing it again in the docs dir seems redundant. @lawruble13, can you think of a better way to do this?

evetsso avatar Nov 28 '23 18:11 evetsso

@evetsso and @cgmb can you please take a look at this again?

saadrahim avatar Dec 04 '23 14:12 saadrahim

@malcolmroberts shall I merge the PR into this repository?

saadrahim avatar Jan 10 '24 14:01 saadrahim

Rebased.

matyas-streamhpc avatar Jan 24 '24 14:01 matyas-streamhpc

Rebased.

matyas-streamhpc avatar Jan 26 '24 13:01 matyas-streamhpc

Closing this PR due to inactivity; feel free to re-open.

malcolmroberts avatar Mar 26 '25 14:03 malcolmroberts