HIP icon indicating copy to clipboard operation
HIP copied to clipboard

Add Unified Memory

Open matyas-streamhpc opened this issue 1 year ago • 1 comments

matyas-streamhpc avatar May 22 '24 16:05 matyas-streamhpc

Send some comments via direct message. The short summary:

  • Add the list of missing CUDA features
  • Add system requirements for Unified Memory
  • Add Performance improvements tips
  • Allocation APIs for System-Allocated Memory? Is this supported?
  • Tutorial is not needed, example is enough.

neon60 avatar May 23 '24 09:05 neon60

@matyas-streamhpc Please rebase your branch on docs/develop

neon60 avatar May 28 '24 13:05 neon60

@matyas-streamhpc rebased the branch.

neon60 avatar Jun 10 '24 19:06 neon60

@neon60 Looks good. Some editorial tweaks:

  • Change the title to Unified Memory Management (UMM)

Document structure

  • Introduction (instead of Concept)
  • System requirements
  • Unified memory programming models
  • Using Unified memory management
  • Example

We have not explained Explicit memory management in the document. It would be good to list the differences between EMM and UMM. Could you consider adding the description after the visual?

Rmalavally avatar Jun 12 '24 20:06 Rmalavally

@neon60 Could you please provide the context for the Compiler Hints for Better Performance section? How does it relate to UMM? Do you mean C++ Compiler hints for better performance?

Rmalavally avatar Jun 12 '24 20:06 Rmalavally

@matyas-streamhpc Can we update the visual to include APU for context as an example of UMM architecture?

Rmalavally avatar Jun 13 '24 14:06 Rmalavally

@matyas-streamhpc @yhuiYH added some comments from a user standpoint. Please feel free to use or ignore them. Let me know if they are not technically applicable or relevant.

Rmalavally avatar Jun 13 '24 16:06 Rmalavally

@matyas-streamhpc @yhuiYH added some comments from a user standpoint. Please feel free to use or ignore them. Let me know if they are not technically applicable or relevant.

@Rmalavally @yhuiYH Thank you very much for your feedback. I updated the page, accordingly.

matyas-streamhpc avatar Jun 14 '24 12:06 matyas-streamhpc

Please fix the following rst issues:

HIP\docs\reference\unified_memory_reference.rst:12: WARNING: Duplicate C++ declaration, also defined at reference/unified_memory_reference:10.
Declaration is '.. cpp:function:: hipError_t hipMallocManaged (void **dev_ptr, size_t size, unsigned int flags)'.
HIP\docs\reference/unified_memory_reference.rst:8: CRITICAL: Duplicate ID: "group___memory_m_1gaadf4780d920bb6f5cc755880740ef7dc".
HIP\docs\reference/unified_memory_reference.rst:8: WARNING: Duplicate explicit target name: "group___memory_m_1gaadf4780d920bb6f5cc755880740ef7dc".
HIP\docs\reference/unified_memory_reference.rst:15: WARNING: doxygenfunction: Cannot find function "hipMemoryAdvise" in doxygen xml output for project "HIP 6.2.0 Documentation" from directory: HIP\docs\doxygen\xml
HIP\docs\reference/unified_memory_reference.rst:17: WARNING: doxygenfunction: Cannot find function "hipMemRangeAttribute" in doxygen xml output for project "HIP 6.2.0 Documentation" from directory: HIP\docs\doxygen\xm

neon60 avatar Jun 14 '24 14:06 neon60