HIP icon indicating copy to clipboard operation
HIP copied to clipboard
verified publisher icon ROCm

Update C++ language extensions

Open matyas-streamhpc opened this issue 1 year ago • 1 comments

matyas-streamhpc avatar May 17 '24 14:05 matyas-streamhpc

I have a few comments. Please update PR accordingly.

TomSang avatar May 21 '24 20:05 TomSang

@matyas-streamhpc rebased your branch and targeted docs/develop

neon60 avatar May 28 '24 12:05 neon60

"hipLaunchParm lp, " should be removed here, // Example hipLaunchKernelGGL pseudocode: global MyKernel(hipLaunchParm lp, float *A, float *B, float *C, size_t N) { ... }

It has been fixed in https://github.com/ROCm/HIP/pull/3488/commits/3be5ac382846443cbcb647734890b6932b649222 (former https://github.com/ROCm/HIP/pull/3488/commits/d518b3a9e4955074b1535a1f8f6b4ed4524bc794)

matyas-streamhpc avatar May 30 '24 12:05 matyas-streamhpc

@matyas-streamhpc rebased your branch and targeted docs/develop

Rebased again.

matyas-streamhpc avatar May 30 '24 13:05 matyas-streamhpc