ROCmValidationSuite icon indicating copy to clipboard operation
ROCmValidationSuite copied to clipboard

Published 20 hours ago • verified publisher icon ROCm-Developer-Tools

JSON output format syntactically correct.

Open avikram2 opened this issue 2 years ago • 3 comments
trafficstars

When I run the pebb module with the -j flag, the tool dumps the bandwidth information in JSON format to a json file in /var/tmp, titled with the system time. The issue is that the file is not syntactically correct JSON, and so I cannot load the file with pythons json library, nor with pandas.read_json function.

Please suggest how to address this issue, as I plan on running the pebb module continuously and want 'a dashboard' of the results.

avikram2 avatar Aug 02 '23 20:08 avikram2

Hi @avikram2 Thanks for reporting issue. Was able to reproduce the issue in pebb json file. Expect the fix soon. Will post here once its merged to mainline,

jkottiku avatar Sep 26 '23 20:09 jkottiku

@jkottiku were you able to resolve the issue?

avikram2 avatar Jan 17 '24 18:01 avikram2

@avikram2 Couldn't complete yet, even though analyzed the issue and started the work sometime back but it got sidelined. Changes involve overall json logging design, json file structure and would impact other modules as well not just pebb. Will resume it this week & keep you posted here.

jkottiku avatar Jan 17 '24 21:01 jkottiku

@avikram2 please check with latest RVS master. Changes to fix the parsing issue are in place. Verified with jq parser on Linux.

manoj-freyr avatar Sep 06 '24 06:09 manoj-freyr

Closing as the issue was fixed in master. Reopen if you see related issues

manoj-freyr avatar Sep 09 '24 07:09 manoj-freyr