qwik icon indicating copy to clipboard operation
qwik copied to clipboard

fix: docs monaco editor suggestion position weird

Open jiawei-hong opened this issue 3 years ago • 1 comments
trafficstars

fix #1732

What is it?

  • [ ] Feature / enhancement
  • [ ] Bug
  • [x] Docs / tests

Description

I remove the Monaco-Editor editor fixedOverflowWidgets param to fix the suggestion position weird. The above operation cannot see all suggestions, So remove packages/docs/src/repl/repl.css L33 to make suggestions can see all.

Use cases and why

    1. docs write code show suggestion is weird / refer playground show correct suggestion position.

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

jiawei-hong avatar Oct 19 '22 14:10 jiawei-hong

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Awesome thanks!

adamdbradley avatar Oct 19 '22 21:10 adamdbradley