qwik icon indicating copy to clipboard operation
qwik copied to clipboard

fix(head): expose frontmatter into runtime head

Open voluntadpear opened this issue 3 years ago • 1 comments
trafficstars

fixes #1762

What is it?

  • [ ] Feature / enhancement
  • [x] Bug
  • [ ] Docs / tests

Description

The additional frontmatter attributes weren't correctly propagated to the head context used in the Qwick city runtime.

This PR adds the missing propagation of the frontmatter property that was generated during buildtime to the runtime.

Use cases and why

When using the useDocumentHead from markdown routes, additional attributes found in the frontmatter should be correctly exposed into the frontmatter property.

Checklist:

  • [x] My code follows the developer guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

voluntadpear avatar Oct 17 '22 04:10 voluntadpear

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Great fix, thanks!

adamdbradley avatar Oct 19 '22 22:10 adamdbradley

@adamdbradley this wasn't released yet right? I checked the changelog and it wasn't there.

ahmadalfy avatar Oct 24 '22 18:10 ahmadalfy

@ahmadalfy Looks like it is in v0.12.0.

HeyITGuyFixIt avatar Nov 01 '22 16:11 HeyITGuyFixIt