qwik icon indicating copy to clipboard operation
qwik copied to clipboard

Published 20 hours ago • verified publisher icon QwikDev

Let developers make their own error pages designs

Open devmousa opened this issue 3 years ago • 1 comments
trafficstars

What is it?

  • [ ] Feature / enhancement
  • [ ] Bug

Description

Let developers make their own error pages designs every error should be in "errors" folder and name it "err-errorNumber-page" where errorNumber is the number of the error "like 400, 405 etc.."

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • [ ] My code follows the developer guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] Added new tests to cover the fix / functionality

devmousa avatar Oct 06 '22 22:10 devmousa

thanks for starting this one 🙏

zanettin avatar Oct 10 '22 13:10 zanettin

We are not sure this is the correct solution, just yet, this issues has implications with deployment providers too, like, this will be only for dev server, not closing or merging until we do more research :)

Thank for the PR!

manucorporat avatar Nov 22 '22 11:11 manucorporat

Hi @mousaAM Thanks once again for creating this PR 🙏 i guess Adam solved this now with this PR https://github.com/BuilderIO/qwik/pull/2175. Hope the implemented solution is what you've expected as well?

zanettin avatar Feb 06 '23 22:02 zanettin

I don't try it yet, but it will be an excellent solution for sure thank you for the comment Mr @zanettin 😊

devmousa avatar Feb 07 '23 05:02 devmousa

Thanks again @mousaAM for taking the time to create a PR for this topic 🙏 it was implemented in the meantime but the core team is still fixing some issue in that regard. That's why i'll close this PR for now. Feel free to create a new PR if you see any possible improvements. Would love to merge them next time 🙏

zanettin avatar Feb 25 '23 20:02 zanettin