FindBar-Tweak icon indicating copy to clipboard operation
FindBar-Tweak copied to clipboard

forward/backward search buttons not working in firefox v53

Open mausalimi opened this issue 8 years ago • 4 comments
trafficstars

hello mr. quicksaver.

starting with firefox v53 there's an issue. steps to reproduce:

  • open an empty tab
  • type some text in the find bar
  • load a site where this test actually appears.

now the find bar shows the number of hits. but the forward/backward search buttons are greyed out. if i press CTRL-F again the buttons do work again.

thanks for developing cool addons in the past.

mausalimi avatar Jan 28 '17 12:01 mausalimi

I've experienced a similar issue, and it occurs pretty regularly. However, for me, sometimes it shows the number of results, and sometimes it shows 0 results even when there are some. It also has nothing to do with starting on a blank page for me; in fact, I don't think I've ever done that. In my case, it seems more related to just switching tabs. I'll do a search on one tab, switch to another and do a search, switch to another and do a search, and after doing this a few times, give or take, it breaks. As mentioned, Ctrl+F fixes it. I'm using Waterfox 56.1.0x64.

vertigo220 avatar May 09 '18 13:05 vertigo220

This symptom (forward/backward search buttons not working) is:

  • reproducible at https://addons.mozilla.org/addon/up-to-eleven/
  • not reproducible at a Wayback Machine capture of the en-US variant of the address, e.g. https://web.archive.org/web/20181020054945/https://addons.mozilla.org/en-US/firefox/addon/up-to-eleven/

From Implementing Content Security Policy - Mozilla Hacks - the Web developer blog (2016-02-16):

The add-ons team recently completed work to enable Content Security Policy (CSP) on addons.mozilla.org (AMO). …

– so I guess that the issue may occur wherever strictness of CSP is in conflict with this feature of FindBar Tweak.

grahamperrin avatar Oct 20 '18 06:10 grahamperrin

This symptom (forward/backward search buttons not working) is:

* reproducible at https://addons.mozilla.org/addon/up-to-eleven/

* **not** reproducible at a Wayback Machine capture of the en-US variant of the address, e.g. https://web.archive.org/web/20181020054945/https://addons.mozilla.org/en-US/firefox/addon/up-to-eleven/

From Implementing Content Security Policy - Mozilla Hacks - the Web developer blog (2016-02-16):

The add-ons team recently completed work to enable Content Security Policy (CSP) on addons.mozilla.org (AMO). …

– so I guess that the issue may occur wherever strictness of CSP is in conflict with this feature of FindBar Tweak.

If you set "security.csp.enableStrictDynamic" to false it will work.

Imold avatar Feb 14 '19 18:02 Imold

about:config?filter=security.csp.enableStrictDynamic

Great! Thanks @Imold

grahamperrin avatar Feb 15 '19 01:02 grahamperrin