Quentin Gabriele

Results 14 comments of Quentin Gabriele

@PerryvanderMeer It makes the test pass which is surprising to me, I was assuming `key` and `wire:key` would have the exact same effect and role. So I took a look...

> @PerryvanderMeer It makes the test pass which is surprising to me, I was assuming `key` and `wire:key` would have the exact same effect and role. > > So I...

The added test in this PR is now passing on the latest version.

> @QuentinGab any chance you can rebase this PR? I've tried with version 3.5.17 and the test passes: > > ![afbeelding](https://private-user-images.githubusercontent.com/11609290/397944914-d8c059aa-bb0e-4347-83ac-f027a55c1405.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ4MDY1NzcsIm5iZiI6MTczNDgwNjI3NywicGF0aCI6Ii8xMTYwOTI5MC8zOTc5NDQ5MTQtZDhjMDU5YWEtYmIwZS00MzQ3LTgzYWMtZjAyN2E1NWMxNDA1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjIxVDE4Mzc1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMwNDU1MzY1ZjgyYjlmYzY5NjI0M2VjMzlhZDE5MmMwNWU5NzNhNzlkN2ViMWE3OWFlYjM2YmM5MGY5OTNhNTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lYls5TuDPh1bO_8-aXLXKcheGqrZE3YsrBBIfeVKq7o) You are right, I have closed the PR.