Quentin Machu
Quentin Machu
This breaks `status`. Reverting `stauts.p9k` to its previous commit (def5835e95ef106162a8443232f643e2317b4cf7) fixes it. The prompt is MUCH faster tho! Thank you!
Yeah, I thought that may become an issue. The `node-role.kubernetes.io` label is the community [accepted](https://github.com/kubernetes/enhancements/blob/143c03f0af52c47eab48ec54144dab6bcc86c98d/keps/sig-architecture/2019-07-16-node-role-label-use.md) label for defining node roles, and more broadly `node-role.kubernetes.io/master=` for master nodes. Right now, we...
Thanks a lot @LeeHampton, that looks much more sensical already!
Wow @LeeHampton, that's some skills! 👏 Thanks!
rebased and addressed @Prototik's comment.
I won't be rebasing right now. I did it yesterday, and fixed conflicts, tests were passing, it has no impact on the reviewability of the project and will break tomorrow...
addressed comments on default role, rebased, passing all tests. not re-tested within live environment after default role change (yet).
@stefanlasiewski It appears so, a rebase was required just 24 hours after the last time I rebased it. Unfortunately, this PR is not getting traction/reviews at the moment, so low...
This would also allow usage of [Topology Aware Routing](https://kubernetes.io/docs/concepts/services-networking/topology-aware-routing/), which was added back in Kubernetes as EndpointSlice hints since 1.23.
Looking forward to seeing this merged, thanks for the contribution, unfortunately still unable to use Terraform management for roles unless column level access is doable.